Closed Bug 1553254 Opened 6 years ago Closed 6 years ago

Allow selective and low-overhead collection of internal performance probes

Categories

(Core :: Performance: General, enhancement)

Product:
Core
Component:
Performance: General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: bas.schouten, Assigned: bas.schouten)

References

Details

Attachments

(3 files)

Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika
47 bytes, text/x-phabricator-request
Details | Review
Bug 1553254 - Part 2: Add some first performance probes to our codebase for some basic, easy to measure things. r=brennie
47 bytes, text/x-phabricator-request
Details | Review
Bug 1553254 - Part 3: Add a simple front-end for developers to get data out of PerfStats on nightly. r=mconley
47 bytes, text/x-phabricator-request
Details | Review

Right now whenever developers are improving components of Firefox that are not a large portion of pageload it is extremely hard to determine the impact of individual patches. I could for example make a 5% improvement to display list building, that would be a great improvement, but the impact it has on BrowserTime will be hidden within the noise of the total system.

By giving developers a way to easily collect total time spent in specific components during automated testing, they will be better able to determine the impact of their individual patches. In addition longer term we could also explore using this for regression testing.

Attachment #9066504 - Attachment description: Bug 1553254: Allow low-overhead selective collection of internal performance probes through nsIDOMWindowUtils. WIP → Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through nsIDOMWindowUtils. r=brennie r=nika
Attachment #9066504 - Attachment description: Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through nsIDOMWindowUtils. r=brennie r=nika → Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through nsIDOMWindowUtils. r=brennie,nika
Flags: needinfo?(bas)
Attachment #9066504 - Attachment description: Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through nsIDOMWindowUtils. r=brennie,nika → Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika
Pushed by bschouten@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/49028e60c0d4 Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika https://hg.mozilla.org/integration/mozilla-inbound/rev/f0310aa07b8f Part 2: Add some first performance probes to our codebase for some basic, easy to measure things. r=brennie

https://hg.mozilla.org/mozilla-central/rev/49028e60c0d4
https://hg.mozilla.org/mozilla-central/rev/f0310aa07b8f

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: